Skip to content

Conversation

@MatthewBonanni
Copy link
Contributor

@MatthewBonanni MatthewBonanni commented Oct 24, 2025

Purpose

#25103 missed the kv cache scale setup when breaking out MLAAttention. This PR adds this to MLAAttention.__init__

cc @pavanimajety

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the missing KV cache scale and quantization setup to the MLAAttention layer. The implementation appears to be a direct copy of the logic from the Attention layer. While this fixes the immediate issue, it introduces significant code duplication. My review includes a suggestion to refactor this common initialization logic into a shared helper function to improve maintainability and avoid potential inconsistencies in the future.

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Copy link
Collaborator

@pavanimajety pavanimajety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix!

@pavanimajety pavanimajety added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 24, 2025
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
@mgoin mgoin added bug Something isn't working deepseek Related to DeepSeek models labels Oct 25, 2025
@vllm-bot vllm-bot merged commit a99564a into vllm-project:main Oct 25, 2025
49 of 51 checks passed
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
@MatthewBonanni MatthewBonanni deleted the fix_scales branch October 27, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working deepseek Related to DeepSeek models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants