Skip to content

Conversation

@yyzxw
Copy link
Contributor

@yyzxw yyzxw commented Oct 27, 2025

Purpose

vLLM does not have enable_reasoning parameter

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: zxw <1020938856@qq.com>
@mergify
Copy link

mergify bot commented Oct 27, 2025

Documentation preview: https://vllm--27550.org.readthedocs.build/en/27550/

@mergify mergify bot added documentation Improvements or additions to documentation tool-calling labels Oct 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the --enable_reasoning parameter from the documentation, as it is not a valid vLLM CLI argument. The change is accurate and improves the documentation.

While reviewing, I discovered a critical bug in the HunyuanA13BReasoningParser that prevents the enable_thinking: false feature from working as intended. The is_reasoning_end method does not correctly process prompt tokens, leading to incorrect behavior when reasoning is disabled via request parameters. I've added a comment with a suggested fix for this issue.

Also, a minor note: the pull request title has a typo ("reemove" instead of "remove").

Overall, the documentation change is good to merge, but I highly recommend addressing the identified bug to ensure the Hunyuan model's reasoning features work correctly.

Copy link
Collaborator

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--enable_reasoning is deprecated.

ref #17452

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup

@vllm-bot vllm-bot merged commit 181bf5b into vllm-project:main Oct 27, 2025
8 of 9 checks passed
xuhaolei pushed a commit to ZJU-REAL/EasySteer-vllm-v1 that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation tool-calling

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants