Skip to content

Conversation

@njhill
Copy link
Member

@njhill njhill commented Oct 30, 2025

Broken by #25775.

Signed-off-by: Nick Hill <nhill@redhat.com>
@njhill njhill added the bug Something isn't working label Oct 30, 2025
@mergify mergify bot added the v1 label Oct 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a broken import for cuda_device_count_stateless in vllm/v1/executor/ray_utils.py. The import path is updated from vllm.utils to vllm.utils.torch_utils, which reflects a recent refactoring. This is a necessary fix to prevent an ImportError at runtime. The change is correct and I have no further suggestions.

@tlrmchlsmth tlrmchlsmth added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 30, 2025
@tlrmchlsmth tlrmchlsmth enabled auto-merge (squash) October 30, 2025 21:10
@hjjq
Copy link
Contributor

hjjq commented Oct 30, 2025

Hi @njhill , can you peg in a docstring fix in this PR? https://github.com/vllm-project/vllm/blob/main/vllm/config/parallel.py#L198

After #25775, ray is no longer a default fallback and needs to be explicitly specified, otherwise an error will be raised.
Also raised by #27823

@njhill
Copy link
Member Author

njhill commented Oct 30, 2025

@hjjq could you open another PR for that. Sorry I'm doing 10 things at once and not sure exactly of the wording change that you're asking for.

@simon-mo simon-mo disabled auto-merge October 30, 2025 23:26
@simon-mo simon-mo merged commit c9791f1 into vllm-project:main Oct 30, 2025
47 of 51 checks passed
@njhill njhill deleted the fix-dist-break branch October 30, 2025 23:49
ZhengHongming888 pushed a commit to ZhengHongming888/vllm that referenced this pull request Nov 8, 2025
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants