Skip to content

[Misc] Add some comments in qwen3-next #28267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2025
Merged

[Misc] Add some comments in qwen3-next #28267

merged 1 commit into from
Nov 9, 2025

Conversation

@ZJY0516
Copy link
Contributor

@ZJY0516 ZJY0516 commented Nov 7, 2025 •
edited by github-actions bot
Loading

Purpose

As discussed in #28182, we should not use torch.empty to allocate attention output buffer in qwen3 Qwen3NextGatedDeltaNet

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@ZJY0516
init
1062d89 
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
@ZJY0516 ZJY0516 requested a review from sighingnow as a code owner November 7, 2025 05:09
@ZJY0516
Copy link
Contributor Author

ZJY0516 commented Nov 7, 2025

cc @vadiklyutiy

@mergify mergify bot added the qwen Related to Qwen models label Nov 7, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a helpful comment to explain why torch.zeros is used instead of torch.empty for allocating the attention buffer in Qwen3NextGatedDeltaNet. This is a good practice for documenting non-obvious design choices. The change is correct and improves code clarity. I have no further comments.

@vadiklyutiy vadiklyutiy self-requested a review November 7, 2025 23:40
@vadiklyutiy vadiklyutiy added ready-for-merge Indicate this PR is ready to be merged by the maintainers, used by reviewers without merge access. ready ONLY add when PR is ready to merge/full CI is needed labels Nov 7, 2025
@ywang96 ywang96 merged commit 7ae5a5f into vllm-project:main Nov 9, 2025
59 checks passed
@ZJY0516 ZJY0516 deleted the q3n-comment branch November 13, 2025 09:38
xuebwang-amd pushed a commit to xuebwang-amd/vllm that referenced this pull request Nov 13, 2025
@ZJY0516 @xuebwang-amd
[Misc] Add some comments in qwen3-next (vllm-project#28267)
6d37f01 
Signed-off-by: zjy0516 <riverclouds.zhu@qq.com>
Signed-off-by: xuebwang-amd <xuebwang@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywang96 ywang96 ywang96 approved these changes

@sighingnow sighingnow Awaiting requested review from sighingnow sighingnow is a code owner

+2 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@vadiklyutiy vadiklyutiy vadiklyutiy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed ready-for-merge Indicate this PR is ready to be merged by the maintainers, used by reviewers without merge access.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZJY0516 @ywang96 @vadiklyutiy