-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[ROCm] Add env to enable/disable aiter triton gemm #28321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
20ac3b0 to
c87094f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces an environment variable VLLM_ROCM_USE_AITER_TRITON_GEMM to control the usage of AITER's Triton GEMM kernel, which is a good addition for backward compatibility. The implementation is straightforward. However, there is a critical issue: the new environment variable, which affects the computation graph, has not been added to the compute_hash function. This can lead to incorrect caching behavior. I've added a comment with details on how to fix this.
|
cc: @gshtras @maleksan85 |
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
Signed-off-by: Yong Hoon Shin <yhshin@meta.com>
Head branch was pushed to by a user without write access
668c0c6 to
b5419b2
Compare
|
@sarckk May I know if you are evaluating against the ROCm aiter version that is specified in the |
|
@sarckk It seems that the API is valid for |
|
@tjtanaa yea in general it would be good to have some option to easily toggle features that rely on the latest AITER version, thanks |
Purpose
#26969 added usage of AITER gemm_a16w16 for GEMM ops on AMD for valid shapes. However, it passes a bias term to
gemm_a16w16that was only added to AITER in ROCm/aiter#1148 (merged Oct 28).Some are still using an older version of AITER. For backward compatibility, we should have an option to disable using this AITER triton gemm kernels.
Test Plan
Test Result
Checked that
VLLM_ROCM_USE_AITER_TRITON_GEMM=0disables it and by default on.Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.