Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Multiprocessing executor for single-node multi-GPU [1/2] #4345

Closed
wants to merge 2 commits into from
Closed

[Core] Multiprocessing executor for single-node multi-GPU [1/2] #4345

wants to merge 2 commits into from

Commits on Apr 25, 2024

  1. [Core] Multiprocessing executor for single-node multi-GPU [1/2] 

    This introduces the MultiProcGPUExecutor which uses multiprocessing for tensor parallel as an alternative to ray.

This PR does not actually wire it up for use, that will be done in a follow-on PR.

This PR includes some refactoring to simplify the executor class hierarchy:
- A `MultiGPUExecutor` abstract superclass shared between ray and vanilla multiprocessing implementations
- Add a shutdown() method to BaseExecutor abstract class
- Simplification/centralization of GPU Worker construction
- Move ray_utils.py from engine to executor package
- Move function call tracing setup to utils function
- Fix various typing things
    @njhill
    njhill committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    13188f1 View commit details
    Browse the repository at this point in the history

  2. Rename function, fix tests, fix yapf

    @njhill
    njhill committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6532881 View commit details
    Browse the repository at this point in the history