Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kernel] Add GPU architecture guards to the CUTLASS w8a8 kernels to reduce binary size #5157

Merged
merged 8 commits into from
Jun 5, 2024

Conversation

tlrmchlsmth
Copy link
Collaborator

@tlrmchlsmth tlrmchlsmth commented May 31, 2024

This PR wraps the CUTLASS kernel definitions in order to guard against compilation on architectures that will never use a particular kernel. The purpose of this is to reduce the size of the compiled binary. Each CUTLASS kernel is defined and optimized for specific GPU architectures, but each kernel is compiled for every arch defined in CUDA_SUPPORTED_ARCHS.

The normal way to deal with this is to look at the macro __CUDA_ARCH__. This macro is defined in the device-specific code but not on the host. All of our code runs on the host, so this PR uses these wrappers to "reach into" the device code to conditionally define the code.

Results:

If I build

export TORCH_CUDA_ARCH_LIST="7.0 7.5 8.0 8.6 8.9 9.0+PTX"
python setup.py build_ext --inplace

and then run the following (the strip is because I forgot to build in release mode):

strip vllm/_C.cpython-310-x86_64-linux-gnu.so
ls -al vllm/_C.cpython-310-x86_64-linux-gnu.so

main

-rwxrwxr-x 1 tms tms 146108048 Jun  4 20:49 vllm/_C.cpython-310-x86_64-linux-gnu.so

this PR:

-rwxrwxr-x 1 tms tms 142900880 Jun  4 20:04 vllm/_C.cpython-310-x86_64-linux-gnu.so

PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@mgoin
Copy link
Member

mgoin commented Jun 1, 2024

This seems reasonable to me (as in not too bad of a way to achieve this), is this in a land-able state given the passing checks?

@tlrmchlsmth
Copy link
Collaborator Author

tlrmchlsmth commented Jun 1, 2024

is this in a land-able state given the passing checks?

It's in a landable state. I want to measure the final size reduction for the wheel file when compiling for all CUDA ARCHS before marking it ready for review. I started to do this Friday but ran into some very long compile times

edit: was in a landable state -- there will likely be merge conflicts now that #5144 has landed

@tlrmchlsmth tlrmchlsmth marked this pull request as ready for review June 4, 2024 21:08
@tlrmchlsmth
Copy link
Collaborator Author

@mgoin @pcmoritz @comaniac @bnellnm ready for review!

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
@simon-mo simon-mo merged commit ccd4f12 into vllm-project:main Jun 5, 2024
88 of 90 checks passed
blinkbear pushed a commit to blinkbear/vllm that referenced this pull request Jun 6, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jun 11, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
@tlrmchlsmth tlrmchlsmth deleted the tms/arch_guard branch June 14, 2024 17:20
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
…educe binary size (vllm-project#5157)

Co-authored-by: Cody Yu <hao.yu.cody@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants