Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Optimization] use a pool to reuse LogicalTokenBlock.token_ids #5584
[Optimization] use a pool to reuse LogicalTokenBlock.token_ids #5584
Changes from all commits
966a86b
f459c31
b079507
dec6d8f
99e7668
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although not as "automatic", it may be more efficient to call a free method explicitly when a
LogicalTokenBlock
is finished with. Since like you say here there is no guarantee about when finalization happens. In my experience it's better to avoid relying on finalization wherever possible.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding a
LogicalTokenBlock.release()
method is easy, but it would be difficult to find all the places to call it. Essentially we need to mimic and track the gc information. Given the complexity, I prefer thefinalization
method, this will guarantee thatself
is destructed beforeself.token_ids
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked but maybe there aren't that many places? In any case it doesn't matter if some place is missed. Either it can be dropped in that case or keep the existing logic to let the finalizer get it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have the bandwidth to check it yet. Feel free to add it later if you figure it out. My intuition is this would need control over the gc system (which is difficult in Python).