Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc][doc] try to add warning for latest html #5979

Merged
merged 12 commits into from
Jul 4, 2024

Conversation

youkaichao
Copy link
Member

first step to make the latest html default

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope that this will reduce the number of issues resulting from users reading latest docs while using stable release.

You can merge this once you're ready.

@youkaichao
Copy link
Member Author

I'm fighting with css/html 😅

@youkaichao
Copy link
Member Author

@simon-mo how do you like this style?

https://vllm--5979.org.readthedocs.build/en/5979/

@DarkLight1337
Copy link
Member

DarkLight1337 commented Jun 29, 2024

Personally I prefer using the same font as the main text, but either way it's ok.

@DarkLight1337
Copy link
Member

@simon-mo any update on this?

@simon-mo
Copy link
Collaborator

simon-mo commented Jul 3, 2024

Looks a bit off in dark mode :(

image

@youkaichao
Copy link
Member Author

@simon-mo feel free to update the PR if you know how to make it work with dark mode. I know little about html/css :( I just ask ChatGPT.

@DarkLight1337
Copy link
Member

Use [data-theme=dark] selector for dark theme and [data-theme=light] for light theme.

@youkaichao
Copy link
Member Author

@DarkLight1337 can you update the pr directly?

@DarkLight1337
Copy link
Member

Looks like I fixed it.

@DarkLight1337
Copy link
Member

@simon-mo how about now?

@DarkLight1337
Copy link
Member

Would be nice if we can get this into the release, otherwise we won't see the effects of this PR until the next release after this one...

@simon-mo simon-mo merged commit 27902d4 into vllm-project:main Jul 4, 2024
68 checks passed
@youkaichao youkaichao deleted the doc_latest branch July 4, 2024 17:45
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants