Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Avoid unnecessary Ray import warnings #6079

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

njhill
Copy link
Member

@njhill njhill commented Jul 2, 2024

Currently the logs are polluted with multiple Ray import warnings when it's not installed, even in cases where Ray is not being used. There should be an error only in the case that Ray is configured and/or required but not available, and in that case it should be fatal.

In our own builds/tests this was also interfering with the subprocess stdout-based custom all-reduce p2p check recently introduced in #5669.

Currently the logs are polluted with multiple Ray import warnings even in cases where Ray is not being used. There should be an error only in the case that Ray is configured and/or required but not available, and in that case it should be fatal.

In our own builds/tests this was also interfering with the subprocess-based custom all-reduce p2p check recently introduced in vllm-project#5669.
@njhill njhill mentioned this pull request Jul 2, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement!

@DarkLight1337 DarkLight1337 merged commit d830656 into vllm-project:main Jul 3, 2024
70 checks passed
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 3, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants