Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc][distributed] error on invalid state #6092

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

youkaichao
Copy link
Member

fixes #6056

give those who are not familiar with this bug a clear message

@youkaichao youkaichao requested a review from DarkLight1337 July 3, 2024 05:45
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the QoL improvement!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 3, 2024 06:12
@youkaichao youkaichao disabled auto-merge July 3, 2024 06:37
@youkaichao youkaichao merged commit f666207 into vllm-project:main Jul 3, 2024
55 of 57 checks passed
@youkaichao youkaichao deleted the error_on_device_count branch July 3, 2024 06:37
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 3, 2024
robertgshaw2-redhat pushed a commit to neuralmagic/nm-vllm that referenced this pull request Jul 7, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants