[core][distributed] allow custom allreduce when pipeline parallel size > 1 #6117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andoorve
approved these changes
Jul 3, 2024
|
I think you already have it:
|
|
I mean should we also test with and without ENABLE_ALL_REDUCE? |
the current main does not test it. it is on by default, and might be turned off when hardware does not support it. |
|
Sure, it makes sense to me |
|
merge as failed tests are unrelated |
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 7, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when pipeline parallel size > 1, we can still use custom allreduce in the tensor parallel group.