[doc][misc] bump up py version in installation doc #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertgshaw2-redhat
approved these changes
Jul 3, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 7, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
many people (including me) just copy-paste the command from doc. we should recommend the most extensively tested python version (python 3.10, used in ci), so that users' environment is more aligned with our ci, and we can catch more bugs there.
in addition, pipeline parallel currently requires python 3.10, as there are some more work to do to support python 3.8/3.9 in terms of asyncio default event loop.
@andoorve is trying to fix it. orthogonally, we can bump up the recommended python version so that users have better experience with pipeline parallel.