[Bugfix] Use templated datasource in grafana.json to allow automatic imports #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imports This is somewhat of a followup to vllm-project#4711 which introducted a input variable to allow setting the datasource on import. Unfortunately this only works when the dashboard is imported via the Grafana UI. It's common to e.g. import dashboard JSON files via ConfigMaps on Kubernetes, so there is no manual step to set the datasource name. Switching to a template var for the datasource also should cover the issue vllm-project#4711 fixed, but also works in setting the datasource when using automatic dashboard provisioning. Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
simon-mo
approved these changes
Jul 5, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jul 7, 2024
…imports (vllm-project#6136) Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
…imports (vllm-project#6136) Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
…imports (vllm-project#6136) Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…imports (vllm-project#6136) Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de> Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use templated datasource in grafana.json to allow automatic imports
This is somewhat of a followup to #4711 which introducted a input variable to allow setting the datasource on import. Unfortunately this only works when the dashboard is imported via the Grafana UI.
It's common to e.g. import dashboard JSON files via ConfigMaps on Kubernetes, so there is no manual step to set the datasource name.
Switching to a template var for the datasource also should cover the issue #4711 fixed, but also works in setting the datasource when using automatic dashboard provisioning.
FIX #4700 (reply in thread)
(^ rather improve on the previous fix ^)