[Doc] Move guide for multimodal model and other improvements #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywang96
approved these changes
Jul 6, 2024
|
I've renamed the guide to "Enabling Multimodal Inputs" to avoid overlap with the base "Adding a New Model". PTAL again. |
ywang96
approved these changes
Jul 6, 2024
Comment on lines
-8
to
-15
| .. note:: | ||
| The complexity of adding a new model depends heavily on the model's architecture. | ||
| The process is considerably straightforward if the model shares a similar architecture with an existing model in vLLM. | ||
| However, for models that include new operators (e.g., a new attention mechanism), the process can be a bit more complex. | ||
|
|
||
| .. tip:: | ||
| If you are encountering issues while integrating your model into vLLM, feel free to open an issue on our `GitHub <https://github.com/vllm-project/vllm/issues>`_ repository. | ||
| We will be happy to help you out! |
There was a problem hiding this comment.
I've already linked users to the base "Adding a New Model" which includes the same content.
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Alvant
pushed a commit
to compressa-ai/vllm
that referenced
this pull request
Oct 26, 2024
…oject#6168) Signed-off-by: Alvant <alvasian@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily moves the multimodal model guide under "Models" section for more visibility. Some other changes: