Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[misc] only tqdm for first rank #6672

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

youkaichao
Copy link
Member

before:

Loading pt checkpoint shards: 0%| | 0/1 [00:00<?, ?it/s]Loading pt checkpoint shards: 0%| | 0/1 [00:00<?, ?it/s]
Loading pt checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 6.22it/s]
Loading pt checkpoint shards: 100%|██████████| 1/1 [00:00<00:00, 5.96it/s]

after:

Loading pt checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████████████| 1/1 [00:00<00:00, 6.08it/s]

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member Author

Using pure text:

Loading pt checkpoint shards: 0% Completed | 0/1 [00:00<?, ?it/s]
Loading pt checkpoint shards: 100% Completed | 1/1 [00:00<00:00, 6.05it/s]

@youkaichao youkaichao merged commit c520124 into vllm-project:main Jul 23, 2024
24 of 27 checks passed
@youkaichao youkaichao deleted the tqdm branch July 23, 2024 04:57
@zhaotyer
Copy link
Contributor

Using pure text:

Loading pt checkpoint shards: 0% Completed | 0/1 [00:00<?, ?it/s]
Loading pt checkpoint shards: 100% Completed | 1/1 [00:00<00:00, 6.05it/s]

good work,tql

xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
gnpinkert pushed a commit to gnpinkert/vllm that referenced this pull request Jul 26, 2024
cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants