Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding f-string to validation error which is missing #6748

Merged

Conversation

luizanao
Copy link
Contributor

@luizanao luizanao commented Jul 24, 2024

FIX #6747

Very minor fix on missing string interpolation.
This will avoid plain non-sense string being returned on API servers implementations.

Before

{
  "object": "error",
  "message": "Unknown model type: {model_type}",
  "type": "BadRequestError",
  "param": null,
  "code": 400
}

After:

{
  "object": "error",
  "message": "Unknown model type: <whatever model type actually is>",
  "type": "BadRequestError",
  "param": null,
  "code": 400
}

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@comaniac comaniac enabled auto-merge (squash) July 24, 2024 15:52
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
@simon-mo simon-mo merged commit 5451463 into vllm-project:main Jul 24, 2024
30 of 41 checks passed
@luizanao luizanao deleted the fix-missing-f-string-on-error branch July 24, 2024 15:57
cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error message returning plain string instead of f-string in image token string retrieval
3 participants