-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Fix] Illegal memory access, FP8 Llama 3.1 405b #6852
[Bug Fix] Illegal memory access, FP8 Llama 3.1 405b #6852
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
Co-authored-by: Tyler Michael Smith <tyler@neuralmagic.com> Co-authored-by: tlrmchlsmth <tyler@neuralmagic.com>
2821151
to
b89e89e
Compare
Whoever merges this can you please add Tyler Michael Smith (tlrmchlsmth) tyler@neuralmagic.com as a co-author? Thanks! |
/ready |
Thanks for the fix! Does this problem reproducible on your end now? If so can we add a unit test? It not then I'm good with CI green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing effort!!
Unfortunately only when we run Llama 405b server on 8xH100 and hit it with a bunch of requests (granted fairly consistently), but not something I think we can get up and running on the CI (although I'm not that spun up on it). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Alvant <alvasian@yandex.ru>
Co-authored-by: Tyler Michael Smith tyler@neuralmagic.com
Should resolve: #6767, #6689 (comment) etc.
Currently the
Sm90ColOrScalarBroadcast
could read off the end of the scales buffer when the batch size is not a multiple of gemm tile size. Added a predicate tensor and usedcopy_if
to prevent this.