Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nightly benchmarking suite] Remove pkill python from run benchmark suite #6965

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

cadedaniel
Copy link
Collaborator

The comment says sometimes kill does not work, so instead we do pkill on python. This doesn't quite right -- kill -9 [gpu proc pid] should be equivalent in signalling power to pkill python.

This allows me to run the benchmark locally while I have other python processes open, e.g. infrastructure monitoring tooling.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@cadedaniel
Copy link
Collaborator Author

cc @simon-mo

@cadedaniel cadedaniel marked this pull request as ready for review July 30, 2024 23:21
@simon-mo simon-mo merged commit 79319ce into vllm-project:main Jul 30, 2024
16 checks passed
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants