Skip to content

[Misc] Deprecation Warning when setting --engine-use-ray #7424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youkaichao merged 12 commits into from
Aug 14, 2024
Merged

[Misc] Deprecation Warning when setting --engine-use-ray #7424

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e968780
[Misc] Warn for as deprecated
wallashss Aug 12, 2024
d7a2540
[Misc] Set --engine-use-ray to raises an error as a deprecated featur…
wallashss Aug 12, 2024
e1bdbb2
[Misc] Fix tests that use --engine-use-ray due to it raises an except…
wallashss Aug 13, 2024
b3303f8
Merge branch 'vllm-project:main' into deprecate_engine_use_ray
wallashss Aug 13, 2024
f4a6e8a
[Misc] Fix test_openapi_server_ray for missing VLLM_ALLOW_ENGINE_USE_…
wallashss Aug 13, 2024
66e8724
[Misc] Fix test_async_llm_engine for missing VLLM_ALLOW_ENGINE_USE_RA…
wallashss Aug 13, 2024
241f7a3
Update vllm/engine/arg_utils.py
youkaichao Aug 13, 2024
2f94098
Update vllm/engine/async_llm_engine.py
youkaichao Aug 13, 2024
f0f0d45
Update vllm/envs.py
youkaichao Aug 13, 2024
3e62d17
fix lint
youkaichao Aug 13, 2024
93821c0
Merge branch 'main' into deprecate_engine_use_ray
wallashss Aug 14, 2024
64089dd
fix linting
wallashss Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,10 @@ def add_cli_args(parser: FlexibleArgumentParser,
parser.add_argument('--engine-use-ray',
action='store_true',
help='Use Ray to start the LLM engine in a '
'separate process as the server process.')
'separate process as the server process.'
'(DEPRECATED. This argument is deprecated '
'and may be removed in a future update. '
'See #7045.)')
parser.add_argument('--disable-log-requests',
action='store_true',
help='Disable logging requests.')
Expand Down
7 changes: 7 additions & 0 deletions vllm/engine/async_llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
from vllm.sampling_params import SamplingParams
from vllm.sequence import ExecuteModelRequest, SamplerOutput
from vllm.usage.usage_lib import UsageContext
from vllm.utils import print_warning_once

logger = init_logger(__name__)
ENGINE_ITERATION_TIMEOUT_S = envs.VLLM_ENGINE_ITERATION_TIMEOUT_S
Expand Down Expand Up @@ -510,6 +511,12 @@ def __init__(self,
self.log_requests = log_requests
self.engine = self._init_engine(*args, **kwargs)

if self.engine_use_ray:
Copy link
Member

@youkaichao youkaichao Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can hard fail here, and put an env var to turn it on with a warning.

something like:

if self.engine_use_ray:
    if envs.VLLM_ALLOW_ENGINE_USE_RAY:
        # print warning
    else:
        # directly error, with the error message pointing to the RFC issue

for the link, please use full url.

Copy link
Contributor Author

@wallashss wallashss Aug 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your comment @youkaichao. I added modifications to address your suggestions.

print_warning_once(
"DEPRECATED. `--engine-use-ray` is deprecated and may "
"be removed in a future update. "
"See #7045.")

self.background_loop: Optional[asyncio.Future] = None
# We need to keep a reference to unshielded
# task as well to prevent it from being garbage
Expand Down