-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature | CI] Added a github action to build wheels #746
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonderful! Thank you so much for this amazing work @Danielkinz !
I've checked that the wheels are automatically generated by the GitHub action, and the wheels can be installed very smoothly on python 3.8, 3.9, 3.10, and 3.11. It also works on the NVIDIA PyTorch containers with CUDA 12 installed. 👍
I only request small changes:
- Could you change the names of the generated wheels from, e.g.,
vllm-0.1.3-cp310-cp310-linux_x86_64.whl
tovllm-0.1.3-cp310-cp310-manylinux1_x86_64.whl
which is compatible with the naming convention in PyPI? - When creating a release, could you also include the auto-generated release note?
- Could you change the GitHub action trigger to any new
v*
tag?
After all, this is very nice work. Thank you so much again @Danielkinz
Thank you for the review @WoosukKwon :) About the requested changes:
|
Hi @Danielkinz,
In summary, the ideal workflow for us is that the GitHub action is triggered when a new |
Alright. I'll take a look at it over the next couple of days :) |
Hi @Danielkinz, what's going on this PR? Please let us know if you need any help. |
Ah sorry about that. Last night I updated the fork and moved some branches around and the fork's main branch ended up on the same commit as the main repo's. Seems like github automatically closes PR's when that happens. |
Hi @Danielkinz, thanks for sharing the status! Then, I think we can manually upload the wheels for now, and implement the feature later. WDYT? This PR is already super awesome. |
As long as you're fine with it. Theoretically the PyPI auto upload should work, I simply can't test it easily. If you'd like you can try it out on the main branch with test.pypi next time there's a release on the main branch, it shouldn't affect the rest of the pipeline. |
Yes, let's have it in a future PR, as many users are waiting for this PR to be merged. 😃 Could you just let me know if 1) the release notes are now auto-generated, and 2) the wheels are renamed to the format like |
Yes, both are implemented. After I test them the PR should be good to go. |
@Danielkinz Great, please let me know if the PR is ready. |
@WoosukKwon The PR is ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Danielkinz LGTM. Thanks for the super awesome work! This will save many users from the tedious installation issues. Great work!
The vLLM notebooks in the the Gaudi-tutorials repo were moved, which resulted in broken links in the README file. This PR fixes those links. Signed-off-by: Dina Suehiro Jones <dina.s.jones@intel.com>
Changes
Created a new action called "Create Release" (publish.yml) which automatically detects a branch of the format "release/<version>", creates a release with same version, build and uploads wheels for said release.
Supported Versions:
The following covers which environments the wheels cover:
Notes
Next Steps