-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] LoRA with lm_head and embed_tokens fully trained #8082
base: main
Are you sure you want to change the base?
[Model] LoRA with lm_head and embed_tokens fully trained #8082
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
/ready |
should it unmarked as Draft ? |
This pull request has merge conflicts that must be resolved before it can be |
/ready |
yes, i am waiting for review |
FIX #4186 #2816
Support lm_head and embed_tokens fully trained in LoRA.
We found that quality of our adapters significantly drops without fully-trained lm_head or lm_head trained in LoRA style.
This is functionality of peft modules_to_save=[lm_head, mebed_tokens] https://huggingface.co/docs/peft/v0.12.0/en/package_reference/#peft.LoraConfig.modules_to_save
The idea is to replace base_model
VocabParallelEmbedding
andParallelLMHead
by layers loaded frommodules_to_save
at inferencing LoRA