Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the AMD weight loading tests #8390

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Fix the AMD weight loading tests #8390

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
22e8f08
Fix the weight loading tests
mgoin Sep 12, 2024
89aec00
Kaichao's fix
mgoin Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vllm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -876,7 +876,7 @@ def __init__(
from vllm.executor import ray_utils
backend = "mp"
ray_found = ray_utils.ray_is_available()
if (torch.cuda.is_available()
if (current_platform.is_cuda()
and cuda_device_count_stateless() < self.world_size):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use if current_platform.is_cuda()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda_device_count_stateless() can raise error in other platforms

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is definitely better to use and seems to work locally

if not ray_found:
raise ValueError("Unable to load Ray which is "
Expand Down
Loading