Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix seeded random sampling with encoder-decoder models #8870

Merged
merged 2 commits into from
Sep 29, 2024
Merged

[BugFix] Fix seeded random sampling with encoder-decoder models #8870

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19a6439
[BugFix] Fix seeded random sampling with encoder-decoder models
njhill Sep 26, 2024
0b4b062
Merge remote-tracking branch 'upstream/main' into fix-enc-dec-seed
ywang96 Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion vllm/worker/enc_dec_model_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,11 +268,13 @@ def prepare_model_input(
encoder_input_positions=encoder_input_positions_tensor,
)

generators = self.get_generators(finished_requests_ids)
sampling_metadata = SamplingMetadata.prepare(seq_group_metadata_list,
model_input.seq_lens,
model_input.query_lens,
self.device,
self.pin_memory)
self.pin_memory,
generators=generators)
is_prompt = (seq_group_metadata_list[0].is_prompt
if seq_group_metadata_list else None)
return dataclasses.replace(model_input,
Expand Down
Loading