-
-
Couldn't load subscription status.
- Fork 10.8k
[BugFix] Fix tool call finish reason in streaming case #9209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
njhill
merged 7 commits into
vllm-project:main
from
maxdebayser:tool_call_finish_reason
Oct 12, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3b75e4f
Fix tool call finish reason in streaming case
maxdebayser 70bc2b8
fix formatting
maxdebayser a4fcd58
Merge branch 'vllm-project:main' into tool_call_finish_reason
maxdebayser a2e141e
fix editing mistake
maxdebayser c08c599
make tool call finish reason consistent with OpenAI platform behavior
maxdebayser 07e94c9
Merge branch 'vllm-project:main' into tool_call_finish_reason
maxdebayser f4992fc
Add comments and improve variable name
maxdebayser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.