Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration to allow output of special tokens #970

Closed
wants to merge 2 commits into from
Closed

Configuration to allow output of special tokens #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39dbd7b
Add option to ModelConfig to keep special tokens in the output instea…
blahblahasdf Sep 6, 2023
10bf588
Update documentation.
blahblahasdf Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions vllm/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ class ModelConfig:
available, and "slow" will always use the slow tokenizer.
trust_remote_code: Trust remote code (e.g., from HuggingFace) when
downloading the model and tokenizer.
keep_special_tokens: Keep special tokens in the generated text.
download_dir: Directory to download and load the weights, default to the
default cache directory of huggingface.
use_np_weights: Save a numpy copy of model weights for faster loading.
Expand All @@ -39,6 +40,7 @@ def __init__(
tokenizer: str,
tokenizer_mode: str,
trust_remote_code: bool,
keep_special_tokens: bool,
download_dir: Optional[str],
use_np_weights: bool,
use_dummy_weights: bool,
Expand All @@ -49,6 +51,7 @@ def __init__(
self.tokenizer = tokenizer
self.tokenizer_mode = tokenizer_mode
self.trust_remote_code = trust_remote_code
self.keep_special_tokens = keep_special_tokens
self.download_dir = download_dir
self.use_np_weights = use_np_weights
self.use_dummy_weights = use_dummy_weights
Expand Down
10 changes: 7 additions & 3 deletions vllm/engine/arg_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class EngineArgs:
tokenizer: Optional[str] = None
tokenizer_mode: str = 'auto'
trust_remote_code: bool = False
keep_special_tokens: bool = False
download_dir: Optional[str] = None
use_np_weights: bool = False
use_dummy_weights: bool = False
Expand Down Expand Up @@ -130,6 +131,9 @@ def add_cli_args(
parser.add_argument('--disable-log-stats',
action='store_true',
help='disable logging statistics')
parser.add_argument('--keep-special-tokens',
action='store_true',
help='keep special tokens in the output')
return parser

@classmethod
Expand All @@ -146,9 +150,9 @@ def create_engine_configs(
# Initialize the configs.
model_config = ModelConfig(self.model, self.tokenizer,
self.tokenizer_mode, self.trust_remote_code,
self.download_dir, self.use_np_weights,
self.use_dummy_weights, self.dtype,
self.seed)
self.keep_special_tokens, self.download_dir,
self.use_np_weights, self.use_dummy_weights,
self.dtype, self.seed)
cache_config = CacheConfig(self.block_size,
self.gpu_memory_utilization,
self.swap_space)
Expand Down
2 changes: 1 addition & 1 deletion vllm/engine/llm_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ def _decode_sequence(self, seq: Sequence) -> None:
self.tokenizer,
seq.output_tokens,
seq.get_last_token_id(),
skip_special_tokens=True,
skip_special_tokens=not self.model_config.keep_special_tokens,
)
if new_token is not None:
seq.output_tokens.append(new_token)
Expand Down
Loading