Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Support bitsandbytes for MiniCPMV #9891

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mgoin
Copy link
Collaborator

@mgoin mgoin commented Oct 31, 2024

Requires #9887

FIX #6932
FIX #7727

Note that the arguments --quantization bitsandbytes --load-format bitsandbytes are required because of the weight -> qweight loading.

Tested with:

vllm serve openbmb/MiniCPM-V-2_6-int4 --trust-remote-code --quantization bitsandbytes --load-format bitsandbytes

and

vllm serve mgoin/MiniCPM-Llama3-V-2_5-int4 --trust-remote-code --quantization bitsandbytes --load-format bitsandbytes

Signed-off-by: mgoin <michael@neuralmagic.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 31, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support!

@DarkLight1337 DarkLight1337 merged commit 93a76dd into vllm-project:main Nov 1, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Model]: MiniCPM-V-2_6-int4 [Feature Request]: Support INT4 for MiniCPM-Llama3-V-2_5
2 participants