Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix MiniCPMV and Mllama BNB bug #9917

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jeejeelee
Copy link
Contributor

@jeejeelee jeejeelee commented Nov 1, 2024

FILL IN THE PR DESCRIPTION HERE

FIX #9914

ping @mgoin

cc @chenqianfzh as well. Regarding multimodal models, additional BNB implementation logic may be required

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Copy link

github-actions bot commented Nov 1, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Copy link
Contributor Author

Now, after fixing this, I can generate reasonable results using my local image

@jeejeelee
Copy link
Contributor Author

Hmm, It seems that BNB has issues handling weights in ReplicatedLinear when TP > 1 @chenqianfzh

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee requested a review from mgoin November 1, 2024 15:29
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee changed the title [Bugfix] Fix MiniCPMV BNB bug [Bugfix] Fix MiniCPMV and Mllama BNB bug Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: minicpmv2.6 BNB in-flight quantization error
2 participants