Move as much data as possible into non-writable text by declaring it const #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"specifics" structures and the tables they point to.
Constify the PER support structure. Constify a few other private tables in the skeleton code.
…e to hold this constant string's address.
vlm
added a commit
that referenced
this pull request
Oct 13, 2014
Move as much data as possible into non-writable text by declaring it const
|
Thank you! |
velichkov
pushed a commit
to velichkov/asn1c
that referenced
this pull request
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing this for threadsafety I noticed a lot of internal tables were in the (read/write) data section instead of the (read-only) text section. This pull request declares everything that is actually constant as 'const', which both makes it clear to the reader that there is not a threadsafety issue, and helps the compiler enforce this invariant, and is a (slight) performance win. This pull request touches a lot of lines but each individual commit should be small enough to review easily.
Most of the remaining global mutable variables are the
asn_TYPE_descriptor_tandasn_TYPE_member_tstructures, since those actually are fixed up at runtime for inherited types.