Merge pull request #388 from jfgarcia268/master

Fix variable reference for OS LWC Compilation and Fix for the unwanted json getting printed during the retry due to LWC
vlocityinc · Jul 27, 2021 · 23c4831 · 23c4831
2 parents 6c6c3d4 + a9f6314
commit 23c4831
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/lib/datapacktypes/omniscript.js b/lib/datapacktypes/omniscript.js
@@ -169,6 +169,10 @@ OmniScript.prototype.onDeployFinish = async function(jobInfo) {
     if (jobInfo.resusableOSToCompile) {
         VlocityUtils.verbose('Parent OmniScripts to Compile', jobInfo.resusableOSToCompile);
         var idsArray = Object.keys(jobInfo.resusableOSToCompile);
+        // To handle the Retry in the case of only manifest error as that prints unwanted json
+        if (idsArray.length < 1){ 
+            return;
+        }   
         VlocityUtils.report('Starting Parent OmniScript LWC Activation', 'Number of OmniScript to Activate: ' + idsArray.length);
         for (let i = 0; i < idsArray.length; i++) {
             var omniScriptId = idsArray[i];
@@ -261,7 +265,7 @@ OmniScript.prototype.compileOSLWC = async function(jobInfo, omniScriptId,omniScr
             }
 
             if (tries == maxNumOfTries) {
-                errorMessage = 'Activation took longer than ' + defaultMinToWaitForLWCOmniScript + ' minutes - Aborting';
+                errorMessage = 'Activation took longer than ' + jobInfo.defaultMinToWaitForLWCOmniScript + ' minutes - Aborting';
             }
 
             if (errorMessage) {
@@ -543,4 +547,4 @@ OmniScript.prototype.getBulkJobObjectName = function() {
 
 OmniScript.prototype.getBulkJobObjectKey =  function () {
     return this.vlocity.namespacePrefix + "OmniScriptId__c";
-}
+}
diff --git a/lib/datapacktypes/vlocitycard.js b/lib/datapacktypes/vlocitycard.js
@@ -27,6 +27,12 @@ VlocityCard.prototype.onDeployFinish = async function(jobInfo) {
         if (jobInfo.ignoreLWCActivationCards) {
             return;
         }
+        // To handle the Retry in the case of only manifest errors as that prints unwanted json
+        var idsArray = Object.keys(jobInfo.flexCardsToCompile);
+
+        if (idsArray.length < 1){ 
+            return;
+        }
 
         try {
 
@@ -231,4 +237,4 @@ VlocityCard.prototype.addParentUILayoutForCard = async function(jobInfo,carKey)
             }
         }
     }
-}
+}