W-12484068: Convert Batch Deployment to Use CSV instead of raw JSON #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change converts the data sent during a batch deployment to CSV format instead of passing raw JSON. This change originated due to an issue with deploying huge Calculation Matrices, where the row data file hit the 10m character limit of the Bulk API. This also adjusts permissions on the TESTVDXProfile Profile used in runTestJob, adding some missing permissions and resolving some issues found while running the test job.
lmckusick
requested review from
mgoldspink-salesforce,
agarcia-sf and
manas-sf
mgoldspink-salesforce
suggested changes
Feb 21, 2023
There was a problem hiding this comment.
@lmckusick I think we need one more change here (which is totally unrelated to what you've done).
I can see CodeShip builds failing and it's because it's using a super old version of node (v10 - https://github.com/vlocityinc/vlocity_build/blob/master/Dockerfile).
Could you please change that to 16 and let's see if that helps the build pass again.
mgoldspink-salesforce
approved these changes
Feb 21, 2023
manas-sf
reviewed
Feb 21, 2023
package.json
Outdated
| @@ -16,12 +16,13 @@ | |||
| "js-yaml": "3.13.1", | |||
| "jsforce": "1.9.3", | |||
| "json-stable-stringify": "1.0.1", | |||
| "runtime-plugin-manager-clone": "0.1.0", | |||
| "json2csv": "^6.0.0-alpha.2", | |||
There was a problem hiding this comment.
Agreed - let's lock it to the version we test with
manas-sf
approved these changes
Feb 21, 2023
Updates Node version from 10 to 16 in Dockerfile. Sets a static version (rather than a minimum one) for json2csv in package.json.
Missed one reference for node version in Dockerfile
agarcia-sf
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change converts the data sent during a batch deployment to CSV format instead of passing raw JSON.
This change originated due to an issue with deploying huge Calculation Matrices, where the row data file hit the 10m character limit of the Bulk API.
This also adjusts permissions on the TESTVDXProfile Profile used in runTestJob, adding some missing permissions and resolving some issues found while running the test job.