[2.1] Move loader creation to the constructor #102
Conversation
|
Could you include a test case that failed before this change please? |
This allow the use of "required" to validate variables without loading without explicitely loading a .env file. Add test case for required validation without loading
louim
force-pushed
the
allow_validation_without_load
branch
from
420f804 to
631e266
Compare
|
@GrahamCampbell Done. |
Move loader creation to the constructor
|
🍻 |
| @@ -35,8 +36,6 @@ public function __construct($path, $file = '.env') | |||
| */ | |||
| public function load() | |||
| { | |||
| $this->loader = new Loader($this->filePath, $immutable = true); | |||
There was a problem hiding this comment.
I don't think this can be removed, but there is not a test case to cover the scenario for why.
Basically, if you call overload, and then load on a different file, the same loader will be retained from overload, which will leave the immutable variable set to false (from the overload method), and the expected behavior will diverge from what this method is supposed to do. A test case needs to be added to ensure this does not happen, and this line probably needs to be added back in. @GrahamCampbell
There was a problem hiding this comment.
So, if i'm getting this right, You would have the line in the constructor and in the load method, and the load method would overwrite the "default" loader with a new one?
GrahamCampbell
changed the title
This allow the use of
$dotenv->requiredto validate environment variables without loading without explicitly loading a .env file. Unless i'm horribly mistaken, this should fix #101 and allow validation environment variables even if we don't use a .env file.