Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set build_min in spell_affect for some Shaman talents that were changed in 1.11. #2315

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

TuriansNotBad
Copy link
Contributor

🍰 Pullrequest

Addressing the changes in 1.11:

  • Talents Concussion and Convection were changed to also affect Lightning Bolt and Chain Lightning.
  • Improved Lesser Healing Wave renamed to Healing Focus and made to affect all healing spells.
  • Improved Mana Spring Totem renamed to Restorative Totems and made to also affect Healing Stream Totems.

Tested 1.10 and 1.12

Proof

  • None

Issues

  • None

How2Test

On 1.10 client:

  • Concussion should not affect Lightning Bolt and Chain Lightning.
  • Convection should not affect Lightning Bolt and Chain Lightning.
  • Improved Lesser Healing Wave should not affect Chain Heal and Healing Wave.
  • Improved Mana Spring Totem should not increase healing of Healing Stream Totems.
  • Newer clients work as before.

Todo / Checklist

  • None

@ratkosrb ratkosrb merged commit 2ff7153 into vmangos:development Nov 30, 2023
1 check passed
Benjaminmnoer pushed a commit to Benjaminmnoer/vmangoscore that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants