Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix option lists in man page and help message #132

Merged
merged 5 commits into from
Sep 14, 2021
Merged

Fix option lists in man page and help message #132

merged 5 commits into from
Sep 14, 2021

Conversation

calvinrw
Copy link
Contributor

  • Fix minor (but confusing to me, unfamiliar with cmake) typo in README
  • Add -n to option list description shown in help text
  • Add -d to and remove -z from option list shown in help text
  • Remove -z from option list in man page

I thought I was losing my mind after upgrading and not seeing an option to log to stdout in the help text.

vmatare
vmatare requested changes Sep 11, 2021
View reviewed changes
Copy link
Owner

@vmatare vmatare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving some attention to these details. If you address these minor change requests it's good to go.

README.md Outdated Show resolved Hide resolved
src/message.h Show resolved Hide resolved
src/thinkfan.1 Show resolved Hide resolved
@vmatare vmatare merged commit 10f74ed into vmatare:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmatare vmatare vmatare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calvinrw @vmatare