Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude test files from the gem package #724

Merged
merged 2 commits into from
Apr 2, 2022
Merged

Conversation

amatsuda
Copy link
Contributor

@amatsuda amatsuda commented Apr 2, 2022

I noticed that the installed redcarpet gem package includes test files that are not usually included in other gems, and misses some documents instead.

So here's a patch that removes the tests and adds three document files.

The reason that I thought why tests are not usually included in other gems is just because the Bundler "new gem" template rejects them. However, this does not necessarily mean that a gem should never include tests. So, feel free to ignore or just close this PR if you're intentionally including them and want to keep shipping gems with tests.

@robin850
Copy link
Collaborator

robin850 commented Apr 2, 2022

It looks like you are right ; the documentation for #files even states:

Only add files you can require to this list, not directories, etc.

And there is #test_files for that. Thank you very much @amatsuda!

@robin850 robin850 merged commit 2488699 into vmg:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants