Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI on GitHub Actions #725

Closed
wants to merge 2 commits into from
Closed

CI on GitHub Actions #725

wants to merge 2 commits into from

Conversation

amatsuda
Copy link
Contributor

@amatsuda amatsuda commented Apr 3, 2022

Here's an attempt to run the CI on GitHub Actions.

Ruby versions in the matrix covers all tested versions on the previous Travis one, plus, 3.0 and 3.1 that were not tested on Travis.

@amatsuda
Copy link
Contributor Author

amatsuda commented Apr 3, 2022

@petergoldstein
Copy link

You may want to:

  1. Add Ruby 3.2 to the matrix
  2. Consider using the bundler-cache option on ruby/setup-ruby over running bundle manually since it better handles using compatible bundler versions.

@amatsuda
Copy link
Contributor Author

amatsuda commented Jun 1, 2023

@petergoldstein Did so! (I don't think that ruby 1.x would run on GHA though)

@petergoldstein
Copy link

@amatsuda Very possibly not. Honestly at this point I'd move the minimum cutoff to 2.2 or possibly even a more recent version.

@robin850 robin850 closed this in 14d3c28 May 31, 2024
@robin850
Copy link
Collaborator

Hello,

I am so sorry for being so long to treat this but your patch has been applied on master with some tweaks to run on latest GitHub Actions.

Thank you very much, this was needed! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants