Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need Automatic Wait Command Line Option #278

Closed
sam-changtum opened this issue Aug 2, 2018 · 9 comments
Closed

Need Automatic Wait Command Line Option #278

sam-changtum opened this issue Aug 2, 2018 · 9 comments
Assignees
@vmi
Milestone
3.19.0

Comments

@sam-changtum
Copy link

Regarding ".side" formatted selenese scripts, and the "click" command for example (especially when AJAX is in play), I am experiencing differences in how Selenese Runner behaves versus how the new Selenium IDE behaves.

It appears the new Selenium IDE automatically "waits" for an element to be present before clicking an element. However, when the Selenese Runner runs the same script, it appears an automatic wait is not being performed.

The end result is a given script will succeed when run from the IDE but fail when run from the Runner.

I am wondering if a command line option is needed, which when set, would instruct the runner to match the new Selenium IDE's "automatic wait behavior".
@vmi vmi self-assigned this Aug 6, 2018
@vmi vmi added this to the 3.18.0 milestone Aug 6, 2018
@vmi vmi modified the milestones: 3.18.0, 3.19.0 Sep 1, 2018
vmi added a commit that referenced this issue Oct 14, 2018
@vmi
wait for the target element to be accessible with the click type comm…
f5bc3b0 
…and. (#278)
@vmi
Copy link
Owner

vmi commented Oct 14, 2018

Hi,

Sorry I'm late.
In the SIDE script, I changed it to wait until the timeout if the target element is not found.

I released 3.19.0, but I have not written the test code, so please try it.

@sam-changtum
Copy link
Author

Hi,

I've downloaded 3.19 and it seems the click command from a SIDE script is timing out after 3 seconds. I do have a "--timeout 60000" setting on the command line. So currently, I think its not working because the click command is not respecting the command line's timeout setting.

@vmi
Copy link
Owner

vmi commented Oct 17, 2018

Hmmm,

Can you provide a test case?

@sam-changtum
Copy link
Author

Hi, thank you for your time on this item.

Script for Selenese Runner Project.zip

When you run the attached "Script for Selenese Runner Project.side" script using the Selenium IDE it succeeds. However, when using the runner, it fails at "click" "css=p.mt-thank-you" with element not found error after a 3 second timeout. So the issue right now is probably the timeout needs to be longer. Currently I am not having any luck with controlling the timeout to make it wait longer; even when using the "--timeout" command line argument.

vmi added a commit that referenced this issue Oct 21, 2018
@vmi
fix: wait for the target element to be accessible with the click type…
9ac9ac4 
… command. (#278)
@vmi
Copy link
Owner

vmi commented Nov 3, 2018

Hi,

I re-fixed this problem and released 3.19.2.
Please test it.

@sam-changtum
Copy link
Author

Hi, I have confirmed this issue is fixed. Thank you very much for your time on resolving this issue. Sorry for being so late at re-testing. Been a bit busy myself.

@sam-changtum
Copy link
Author

Re-ran the test case and confirmed the issue is resolved.

@xiaospider
Copy link

Selenium IDE add wait for commands after 3.4.0. https://github.com/SeleniumHQ/selenium-ide/releases/tag/v3.4.0

Added new commands wait for element editable, wait for element not editable, wait for element present, wait for element not present, wait for element visible, wait for element not visible.

@vmi Do selenese runner plan to support those command? If I record .side with 3.4.0 IDE, Selenese throw exception now.

vmi added a commit that referenced this issue Dec 17, 2018
@vmi
Merge pull request #288 from vmi/improve-side-support-wip
2246e46 
Improve SIDE support.

* Add flow control conmands of SIDE format: (PR #288)
    * `do` ... `repeatIf`
    * `if` ... `elseIf` ... `else` ... `end`
    * `times` ... `end`
    * `while` ... `end`
* Add new commands of SIDE format: (the comment by @xiaospider in #278, PR #288)
    * `assert`
    * `verify`
    * `waitForElementEditable`
    * `waitForElementNotEditable`
    * `waitForElementVisible`
    * `waitForElementNotVisible`
    * `executeScript`
@vmi
Copy link
Owner

vmi commented Dec 29, 2018

Hi, @xiaospider

Do selenese runner plan to support those command?

I added these commands in 3.20.0.
Please test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmi vmi

Labels
None yet
Projects
None yet
Milestone
3.19.0
Development

No branches or pull requests
3 participants
@vmi @xiaospider @sam-changtum