Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner.setupMaxTimeTimer() should be public #309

Closed
shenlian8 opened this issue Oct 2, 2019 · 2 comments
Closed

Runner.setupMaxTimeTimer() should be public #309

shenlian8 opened this issue Oct 2, 2019 · 2 comments

Comments

@shenlian8
Copy link
Contributor

Hi,

the access modifier of function Runner.setupMaxTimeTimer() is default.

/**
 * Setup MaxTimeActiveTimer.
 * @param maxTime the maxTime in milliseconds.
 */
void setupMaxTimeTimer(long maxTime) {
    this.maxTimeTimer = new MaxTimeActiveTimer(maxTime);
}

As I am using this function in another package would you please change this function in public, like other functions.

It should be nice if you can make the change from 3.24.

Thanks!

Lian

@vmi vmi self-assigned this Oct 6, 2019
@vmi vmi added the enhancement label Oct 6, 2019
@vmi
Copy link
Owner

vmi commented Oct 21, 2019

Hi,

I made Runner#setupMaxTimeTimer() public,
and released 3.27.1.
Please check it.

@shenlian8
Copy link
Contributor Author

Yes it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants