Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why assertElementPresent take screenshot by screenshot-all=true? #316

Open
shenlian8 opened this issue Jan 10, 2020 · 2 comments
Open

Why assertElementPresent take screenshot by screenshot-all=true? #316

shenlian8 opened this issue Jan 10, 2020 · 2 comments
Assignees
@vmi
Labels
bug please confirm

Comments

@shenlian8
Copy link
Contributor

Hi,

I set screenshot-all=true.

And when I use assertElementPresent command, it takes still screenshot.

Why this happens? Thanks!

Best regards

Lian
@vmi vmi self-assigned this Feb 2, 2020
@vmi vmi added the bug label Feb 2, 2020
vmi added a commit that referenced this issue Feb 2, 2020
@vmi
don't take screenshots with assert* and selectFrame commands. (#315, …
076bc19 
…#316)
@vmi
Copy link
Owner

vmi commented Feb 2, 2020

Hi,

I fixed this problem and and released 3.29.0.
Please test it.

@shenlian8
Copy link
Contributor Author

Hi,

I am sorry!

I thought about it. All of the assert should take as default screenshot, as I'd like to see what happens on the time I do assert.

What do you think about it?

Lian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmi vmi

Labels
bug please confirm
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmi @shenlian8