Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenese enters infinite loop when using "run" command #320

Closed
billxiao opened this issue Aug 7, 2020 · 3 comments
Closed

Selenese enters infinite loop when using "run" command #320

billxiao opened this issue Aug 7, 2020 · 3 comments
Assignees
Milestone

Comments

@billxiao
Copy link

billxiao commented Aug 7, 2020

Hi,

When I run the attached simple SIDE file, Selenese-runner-java would enter infinite loop. The SIDE file is actually very simple, only containing a "run" command which calls another simple test case.

I believe this is a bug. Please have a look.

The command line I used to run the SIDE is like the following:
java -jar selenese-runner.jar --driver chrome --max-retries=3 D:\asd.side

asd.zip

@billxiao
Copy link
Author

billxiao commented Aug 7, 2020

Finally I spot the bug. It's the "run" command where the retry times in the context is reset by its sub test case. So "run" command will never reach max retries and be locked in an infinite loop.

My solution is to never retry "run" command and once return from the execution of sub test case, set the retries in the context to be max to let it break out of the while loop.

@vmi vmi self-assigned this Aug 13, 2020
@vmi vmi added the bug label Aug 13, 2020
@vmi vmi added this to the 3.32.0 milestone Aug 15, 2020
vmi added a commit that referenced this issue Nov 3, 2020
change not to retry the composite command if an error occurs. (#320)
@vmi
Copy link
Owner

vmi commented Nov 7, 2020

Sorry for being late.
I have released version 3.32.0 that fixes this problem.
Please check it.

@vmi
Copy link
Owner

vmi commented Dec 9, 2020

Please re-open this issue if your problem is not resolved.

@vmi vmi closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants