Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore non text nodes from selenese html #271

Merged
merged 3 commits into from
Mar 31, 2018
Merged

Ignore non text nodes from selenese html #271

merged 3 commits into from
Mar 31, 2018

Conversation

janblok
Copy link
Contributor

@janblok janblok commented Mar 29, 2018

We use Katalon Recorder to get selenese which includes stuff like tags inside a selenese command target table column.
This change drops anything not being text. (which makes the katalon recorder output run without changes)

… run katalon recorder scripts (which contain datalist tags which should be ignored)
@vmi vmi merged commit c8c7b7f into vmi:master Mar 31, 2018
@vmi
Copy link
Owner

vmi commented Mar 31, 2018

Thank you for PR!

I merged your code.

In addition, does "switch to latest jmte lib" patch works correctly?
If so, I would like you to pull request it.

@janblok
Copy link
Contributor Author

janblok commented Apr 1, 2018

Latest jmte uses an very old version of asm.
I also did a pull request at jmte, when merged and released I will do an upgrade pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants