Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecuteAsyncScript: Only check for thenable #332 #333

Merged
merged 2 commits into from
Mar 30, 2022
Merged

ExecuteAsyncScript: Only check for thenable #332 #333

merged 2 commits into from
Mar 30, 2022

Conversation

blutorange
Copy link
Contributor

@blutorange blutorange commented Mar 30, 2022 •
edited
Loading

  • Fixes ExecuteAsyncScript not working with Firefox #332, see there for more details
  • Add test cases for executeAsyncScript to illustrate the issue with Firefox
  • Only check whether promise is thenable, e.g. whether it is truthy and has a then property of type function

@vmi vmi merged commit d717151 into vmi:master Mar 30, 2022
@vmi vmi self-requested a review March 30, 2022 10:18
@blutorange
Copy link
Contributor Author

That was quick, thanks. Doesn't have to be immediate, but it would great if you could make a patch release during the next few weeks.

@vmi
Copy link
Owner

vmi commented Apr 3, 2022

@blutorange I released 4.1.0.
Please check it out.

@blutorange
Copy link
Contributor Author

@vmi I just tried it with our tests and it works now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmi vmi Awaiting requested review from vmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExecuteAsyncScript not working with Firefox
2 participants
@blutorange @vmi