Add script names for scalajs-bunlder bundles #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vmunier It would be really helpful if you got a minute to review and possibly merge this. Thanks for your hard work! 👊 |
|
I completely forgot about this issue... PR merged, thank you both! I will release a new version when bintray is back up. |
|
scalajs-scripts |
|
You're the man! 💪 Thanks! |
rtyley
added a commit
to rtyley/scalajs-scripts
that referenced
this pull request
Aug 3, 2019
When using the scalajs-bundler sbt plugin: https://github.com/scalacenter/scalajs-bundler ...and deploying to Heroku, I've had problems with the `project-opt.js` artifact being selected over the `project-opt-bundle.js` artifact which is required - I _think_ `-bundle` artifacts should be preferred - `selectScript.scala.html` only selects one, so it should be the `-bundle` one. This follows on from vmunier#17 Until this fix is released, a workaround for this issue is to hack the value of the `resourceExists` function sent to `selectScript.scala.html`, eg adding `&& name.contains("-bundle")`: ``` @scalajs.html.scripts( buildinfo.BuildInfo.name, routes.Assets.versioned(_).toString, name => getClass.getResource(s"/public/$name") != null && name.contains("-bundle") ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a proposition to manage scripts generated by scalajs-bundler.