This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(core): lit lifecycle type #6667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes change from upstream lit release - closes #6654 Signed-off-by: Cory Rylan <splintercode.cb@gmail.com>
coryrylan
commented
Feb 9, 2022
bdryanovski
approved these changes
Feb 9, 2022
mathisscott
approved these changes
Feb 9, 2022
| @@ -99,7 +99,7 @@ export class CdsInternalControlInline extends CdsControl { | |||
| ); | |||
| } | |||
|
|
|||
| updated(props: Map<string, any>) { | |||
| updated(props: PropertyValues<any>) { | |||
There was a problem hiding this comment.
Why are the others PropertyValues<this> but this one is PropertyValues<any>?
There was a problem hiding this comment.
14 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Lit released a non-backwards compatible change to a TS type on the LitElement base class. This type is more accurate but causes a build error if a downstream component implements the type incorrectly. This caused any project not using pinned dependencies (stackblitz primarily) to start breaking when using Core.
Issue Number:
#6654
lit/lit#2513
What is the new behavior?
This updates all lifecycle hooks to use the correct
PropertyValuestypeDoes this PR introduce a breaking change?
Other information