This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
Add blackbox exporter #1045
Closed
Add blackbox exporter #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Thank you very much for the PR! I believe this should be part of a new BKPR release branch, as it is adding a new image. I will put the PR on hold until we work on this. |
javsalgar
suggested changes
Jan 12, 2021
| local kubecfg = import "kubecfg.libsonnet"; | ||
|
|
||
| // Cluster-specific configuration | ||
| local BLACKBOX_EXPORTER_IMAGE = "bitnami/blackbox-exporter:0.18.0-debian-10-r83"; |
There was a problem hiding this comment.
This should be in manifests/components/images.json, as that file is automatically updated by our CI/CD system.
| { | ||
| local this = self, | ||
|
|
||
| be_config:: { |
There was a problem hiding this comment.
Could you explain this configuration?
There was a problem hiding this comment.
This is just the default config from https://github.com/prometheus/blackbox_exporter/blob/master/blackbox.yml.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added the blackbox exporter.
Fixes #1036
Cheers,
floek