This repository has been archived by the owner on Nov 20, 2020. It is now read-only.
Check role before changing #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 29, 2019 11:08
This also puts the initial get in a try block to stop failure due to account not existing. Without checking first, if attempting to create an account that already exists, an exception occurs due to a 4xx return status from nsx.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
Uses 'fail_mode="continue"' in NsxClient instantiation to stop it from failing when a non 2xx status is returned from NSX.
Added a true/false return to the getter method that is then used to determine if a change is actually required.
Added logic to only make changes if necessary.