Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Make Mac menu item useful, or remove it #2012

Closed
scothis opened this issue Feb 17, 2021 · 6 comments · Fixed by #2411 or #2419
Closed

Make Mac menu item useful, or remove it #2012

scothis opened this issue Feb 17, 2021 · 6 comments · Fixed by #2411 or #2419
Assignees
Labels
enhancement New feature or request

Comments

@scothis
Copy link
Contributor

scothis commented Feb 17, 2021

Describe the problem/challenge you have

The Octant electron app is adding a menu bar item. These icons are typically used for quick access to common functions while in any other application and quick status (volume, wifi signal strength, time, etc).

The current icon provides no status and the menu provides no meaningful actions.

Screen Shot 2021-02-16 at 8 03 21 PM

Describe the solution you'd like

Minimally, remove all color to match the silhouette style of other icons.

Better is to make the menu useful, or remove it. The current menu options are more appropriate on the Dock icon.

Environment:

  • Octant version (use octant version): 0.17.0
  • Kubernetes version (use kubectl version): n/a
  • OS (macOS 10.15, Windows 10, Ubuntu 19.10 etc): macOS 11.2.1
@wwitzel3 wwitzel3 added the enhancement New feature or request label Feb 17, 2021
@wwitzel3
Copy link
Contributor

Agreed, we have some plans for 0.18 to make this actually have some status of the current cluster/namespace. We'll use this issue to track that.

@xtreme-vikram-yadav
Copy link
Contributor

Hey @wwitzel3, can you confirm what status(es) from a cluster should be shown in the menu?

@GuessWhoSamFoo
Copy link
Contributor

There isn't a definitive answer for this. Maybe the tray icon can have colors as a status indicator is any object status items are in warning/error state. Or perhaps a list of context names to quickly pull down from?

@scothis
Copy link
Contributor Author

scothis commented Apr 21, 2021

Maybe the tray icon can have colors as a status indicator

For mac OS the icon should not have color, unless something is very wrong. The only color on the built-in menu items is when the battery is about to die, otherwise they are all silhouettes.

@xtreme-vikram-yadav
Copy link
Contributor

xtreme-vikram-yadav commented Apr 22, 2021

Keeping the icon in greyscale sounds good. Taking a hint from docker desktop, we can consolidate the two ideas and show the status indicator and list of context/namespaces as a menu item.
Screen Shot 2021-04-22 at 12 43 42 PM

@xtreme-vikram-yadav xtreme-vikram-yadav self-assigned this Apr 26, 2021
@GuessWhoSamFoo
Copy link
Contributor

Let's start by duplicating some of the current menu items under the helper menu on the top right. Eventually when we move away from a binary, we can remove the duplicate menu items from front end once we fully move to electron.

For this issue, add:

  • Open an issue button
  • Contexts (which could duplicate the kubectl method rather than changing contexts in memory)
  • Possibly a Restart (for use cases with installing go plugins)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
4 participants