This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Octant should not crash on startup due to plugin errors #2796
Labels
Comments
xtreme-vikram-yadav
pushed a commit
to xtreme-vikram-yadav/octant
that referenced
this issue
Aug 24, 2021
- Do not error out from octant when plugin startup fails vmware-archive#2796
xtreme-vikram-yadav
pushed a commit
to xtreme-vikram-yadav/octant
that referenced
this issue
Aug 24, 2021
- Do not error out from octant when plugin startup fails Signed-off-by: Vikram Yadav <yvikram@vmware.com> vmware-archive#2796
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the problem/challenge you have
Octant currently fails to start up when a plugin throws an error. This is different behavior from the plugin watch functionality where the new plugin errors are logged but octant keeps functioning correctly.
Steps to reproduce:
Add a panic("") here: https://github.com/vmware-tanzu/octant/blob/71e75e12b05764588d3f0aede455d143e35a3355/cmd/octant-sample-plugin/main.go#L31.
Restart octant.
Octant fails to start with error:
`unable to start runner: failed to start service api: start plugin manager: get rpc client for "octant-sample-plugin.exe": Unrecognized remote plugin message:
This usually means that the plugin is either invalid or simply
needs to be recompiled to support the latest protocol.
exit status 1
`
Describe the solution you'd like
Octant should log plugin runtime errors but continue to work correctly.
Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Environment:
octant version): 0.23The text was updated successfully, but these errors were encountered: