Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Vertical Navigation redesign #1475

Merged
merged 3 commits into from
Oct 20, 2020
Merged

Conversation

mklanjsek
Copy link
Contributor

Navigation redesign based on #1353. After going through a few iterations, we settled down on a module based two panel solution that still supports collapsed and expanded state and moves some of the rarely used actions to keyboard shortcuts for now and Preferences in future. 

Major changes:

  • removed the Navigation Collapse/Expand toggle that used to take a lot of space at the top - that is now available only through <Ctrl><Shift>N and will be soon added to Preferences, 
  • similarly, removed the Light/Dark theme switch - now available only through <Ctrl><Shift>T,
  • the main navigation is now separated into two vertical panels: modules on the left and list of items that belong to selected module on right(right panel is collapsable),
  • reorganized modules grouping, so module scoped plugins are recognized now, 
  • added the module description card to display details about each module - currently that's only a text field, should have rich content in future,
  • Added optional labels to module icons, toggle with <Ctrl><Shift>L,   

Which issue(s) this PR fixes

@GuessWhoSamFoo
Copy link
Contributor

Can you rebase this?

@mklanjsek mklanjsek force-pushed the nav-redesign branch 2 times, most recently from c851d5d to d9fd41a Compare October 9, 2020 15:59
@wwitzel3
Copy link
Contributor

wwitzel3 commented Oct 9, 2020

Using the new design, I think we need to add the chevrons for expanding back to the bottom, I'm using it way more often than I realized, especially when dealing with CRDs, and yes, I can learn the keyboard shortcut, but I'm already using my mouse many times and so that ends up being slower.

@mklanjsek
Copy link
Contributor Author

@wwitzel3 I still feel that should live in preferences dialog. Combination of preferences dialog plus a shortcut should cover most user cases.

Additionally, moving it to the bottom would break Clarity conventions, so I would be reluctant to do that. Bringing it back to the top defies the purpose since it is undeservingly using the prime screen space.

Once we have preferences module, maybe this should be one of the frequently used toggles that are placed inside the Preferences Description section? Theme could go there as well...

@GuessWhoSamFoo
Copy link
Contributor

How about adding the expand/collapse button as a menu item? Removing the button entirely is likely breaking some clarity convention anyway.

@mklanjsek
Copy link
Contributor Author

@GuessWhoSamFoo - what do you exactly mean by menu item? Why would that be better than preferences?

@wwitzel3
Copy link
Contributor

wwitzel3 commented Oct 9, 2020

If we are going to remove the chevrons for menu expansion, then we need the settings / preferences exposed at the bottom of the menu so it can be switched without needing to lookup / known the keyboard short cut, especially for new users.

If we want to open that as another issue, that's fine with me.

@wwitzel3
Copy link
Contributor

wwitzel3 commented Oct 11, 2020

The keyboard shortcuts need to indicate that <Shift> is required.

@mklanjsek
Copy link
Contributor Author

That makes sense, I opened #1498 to track UI for handling Preferences.

@mklanjsek mklanjsek requested a review from a team October 12, 2020 13:29
@mklanjsek
Copy link
Contributor Author

@GuessWhoSamFoo PTAL

Copy link
Contributor

@GuessWhoSamFoo GuessWhoSamFoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can you squash before merging?

Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
@mklanjsek mklanjsek merged commit e0ad3d0 into vmware-archive:master Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Left Navigation redesign
3 participants