This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Fixed issues with incorrect urls on Windows #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
|
I'd like to see a test for this across all modules or moving this to a common helper to generate root paths. |
Signed-off-by: Milan Klanjsek <mklanjsek@pivotal.io>
|
thanks @GuessWhoSamFoo , decided to create path_util package and refactored code to use it. |
GuessWhoSamFoo
approved these changes
Jan 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases when doing url string manipulations, we were using
filepathinstead ofpathgo package. Using OS specificfilepathpackage on Windows resulted in incorrect urls that contain backslashes, as noted in #1696.The original problem from #1696 is not present any more because that code is eliminated with latest breadcrumbs improvements. However, I found another occurrence where
filepathwas used when generating navigation entries and fixed it in this PR.Big thanks to @lgellrich for correctly identifying the problem.
Signed-off-by: Milan Klanjsek mklanjsek@pivotal.io
Which issue(s) this PR fixes